You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update imports, injections, and constructor types.
Adjust tests and mock beans accordingly.
Diagram Walkthrough
flowchart LR
a["OfficialCodebloomEmail"]
b["OfficialCodebloomEmailClient"]
c["GithubOAuthEmail"]
d["GithubOAuthEmailClient"]
e["ReactEmailClient"]
f["ReactEmail"]
g["ReactEmailClientImpl"]
h["ReactEmailImpl"]
i["AuthController imports"]
j["PlaywrightClient imports"]
k["Tests and mocks"]
a -- "renamed to" --> b
c -- "renamed to" --> d
e -- "renamed to" --> f
g -- "renamed to" --> h
i -- "use new client types" --> b
i -- "use new template interface" --> f
j -- "use new Github client" --> d
k -- "updated to new names" --> b
k -- "updated to new names" --> d
k -- "updated to new names" --> f
Verify that the new OfficialCodebloomEmailClientProperties class is correctly bound at runtime (matching property prefixes in application configs) and that only the new properties class is enabled for this client.
After renaming ReactEmailClient to ReactEmail, confirm there is exactly one Spring bean (ReactEmailImpl) implementing the interface and that all injection points across the app were updated to avoid ambiguity.
Ensure the context provides a GithubOAuthEmailClient bean wherever PlaywrightClient is constructed, and that no lingering references to the old GithubOAuthEmail remain in other modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
748
Description of changes
Checklist before review
Screenshots
Dev
Staging